[ 
https://issues.apache.org/jira/browse/HBASE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yu Li updated HBASE-15324:
--------------------------
    Attachment: HBASE-15324_v3.patch

new patch trying to fix checkstyle complaint about import order. It seems 
eclipse's auto import organization could not pass checkstyle, I guess it 
expects  strict dictionary order? 

Regarding the UT failures, all irrelative to the patch here. Probably 
introduced by HBASE-15222 and [commens 
there|https://issues.apache.org/jira/browse/HBASE-15222?focusedCommentId=15166747&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15166747]
 already trying to fix them.

> Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy 
> and trigger unexpected split
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15324
>                 URL: https://issues.apache.org/jira/browse/HBASE-15324
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.3
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-15324.patch, HBASE-15324_v2.patch, 
> HBASE-15324_v3.patch
>
>
> We introduce jitter for region split decision in HBASE-13412, but the 
> following line in {{ConstantSizeRegionSplitPolicy}} may cause long value 
> overflow if MAX_FILESIZE is specified to Long.MAX_VALUE:
> {code}
> this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 
> 0.5D) * jitter);
> {code}
> In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target 
> region to split.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to