[ 
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168084#comment-15168084
 ] 

Sean Busbey commented on HBASE-15222:
-------------------------------------

{quote}
Sean Busbey Any changes to a module are not being picked up by dependent 
modules in the pre-commit builds.
{quote}

Okay, sounds like the same situation as HBASE-15180. Paraphrasing [my longer 
answer there about module 
independence|https://issues.apache.org/jira/browse/HBASE-15180?focusedCommentId=15148845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15148845]:
 I think a new feature in Yetus that allowed projects to opt-in for "also build 
any module that depends on a changed module" would be good general purpose 
addition, but I am skeptical that it would be advisable for HBase as-is due to 
the already extensive time it takes to get through our precommit checks.

A possible middle ground I did not mention there: we could make our personality 
build the entire project at the top level if hbase-server is in the change 
list, since it is the vast majority of our build/test time. That won't help all 
the time, but it would have caught this specific issue.

> Use less contended classes for metrics
> --------------------------------------
>
>                 Key: HBASE-15222
>                 URL: https://issues.apache.org/jira/browse/HBASE-15222
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.2.0, 1.3.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-15222-ADD-0.patch, HBASE-15222-v1.patch, 
> HBASE-15222-v10.patch, HBASE-15222-v11.patch, HBASE-15222-v12.patch, 
> HBASE-15222-v13.patch, HBASE-15222-v2.patch, HBASE-15222-v3.patch, 
> HBASE-15222-v5.patch, HBASE-15222-v6.patch, HBASE-15222-v8.patch, 
> HBASE-15222-v9.patch, HBASE-15222.patch
>
>
> Running the benchmarks now, but it looks like the results are pretty extreme. 
> The locking in our histograms is pretty extreme.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to