[
https://issues.apache.org/jira/browse/HBASE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148603#comment-13148603
]
stack commented on HBASE-3433:
------------------------------
+1 on commit. Some minors below that can be addressed on commit. We can't add
this to 0.92?
Does the below have to be public rather than package private?
{code}
+ public Filter getFilter() {
{code}
I like your transform addition to the Filter Interface.
I think you need to say a little more in Filter#transform javadoc; you should
say that the transform is what is actually returned to the client and perhaps
point at keyonlyfilter as example usage. Filters are hard. Poor fellas trying
to make sense of them need all the pointers possible.
> Remove the KV copy of every KV in Scan; introduced by HBASE-3232 (why doesn't
> keyonlyfilter make copies rather than mutate -- HBASE-3211)?
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-3433
> URL: https://issues.apache.org/jira/browse/HBASE-3433
> Project: HBase
> Issue Type: Improvement
> Components: performance, regionserver
> Reporter: stack
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.0
>
> Attachments: 3433-v2.txt, 3433.txt, HBASE-3433-sidenote.patch
>
>
> Here is offending code from inside in StoreScanner#next:
> {code}
> // kv is no longer immutable due to KeyOnlyFilter! use copy for safety
> KeyValue copyKv = new KeyValue(kv.getBuffer(), kv.getOffset(),
> kv.getLength());
> {code}
> This looks wrong given philosophy up to this has been avoidance of
> garbage-making copies.
> Maybe this has been looked into before and this is the only thing to be done
> but why is KeyOnlyFilter not making copies rather than mutating originals?
> Making this critical against 0.92.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
