[
https://issues.apache.org/jira/browse/HBASE-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179809#comment-15179809
]
Hadoop QA commented on HBASE-14030:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 11 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 37s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 41s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 21m
39s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
34s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m
24s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 9m 39s
{color} | {color:red} branch/. no findbugs output file
(./target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 48s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 24s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 19s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 32s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 13m 9s
{color} | {color:red} Patch generated 23 new checkstyle issues in root (total
was 270, now 266). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 3m 50s
{color} | {color:red} Patch generated 23 new checkstyle issues in hbase-server
(total was 269, now 265). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
3s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 136 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 4s
{color} | {color:red} The patch has 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 30s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m
18s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 8m 54s
{color} | {color:red} patch/. no findbugs output file
(./target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 15s
{color} | {color:red} hbase-server introduced 17 new FindBugs issues. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 7s
{color} | {color:red} root-jdk1.8.0 with JDK v1.8.0 generated 7 new issues (was
15, now 22). {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 7s
{color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 13 new
issues (was 1, now 14). {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 51s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 52s
{color} | {color:red} root-jdk1.7.0_79 with JDK v1.7.0_79 generated 7 new
issues (was 20, now 27). {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 52s
{color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 13
new issues (was 1, now 14). {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 44s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 29m 6s {color}
| {color:red} root in the patch failed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 9s
{color} | {color:green} hbase-common in the patch passed with JDK v1.8.0.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 42s
{color} | {color:green} hbase-protocol in the patch passed with JDK v1.8.0.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 48s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 144m 17s
{color} | {color:green} root in the patch passed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 18s
{color} | {color:green} hbase-common in the patch passed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s
{color} | {color:green} hbase-protocol in the patch passed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 127m 13s
{color} | {color:green} hbase-server in the patch passed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
28s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 474m 53s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Call to String.equals(org.apache.hadoop.hbase.TableName) in
org.apache.hadoop.hbase.backup.HBackupFileSystem.getTableDesc(TableName) At
HBackupFileSystem.java: At HBackupFileSystem.java:[line 98] |
| |
org.apache.hadoop.hbase.backup.impl.BackupManifest.setIncrementalTimestampMap(BackupProtos$BackupManifest$Builder)
makes inefficient use of keySet iterator instead of entrySet iterator At
BackupManifest.java:keySet iterator instead of entrySet iterator At
BackupManifest.java:[line 518] |
| |
org.apache.hadoop.hbase.backup.impl.BackupManifest$BackupImage.compareTo(BackupManifest$BackupImage)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead At BackupManifest.java:constructor; use Long.valueOf(String) instead
At BackupManifest.java:[line 218] |
| | Call to String.equals(org.apache.hadoop.hbase.TableName) in
org.apache.hadoop.hbase.backup.impl.BackupManifest$BackupImage.hasTable(TableName)
At BackupManifest.java: At BackupManifest.java:[line 207] |
| | org.apache.hadoop.hbase.backup.impl.BackupManifest$BackupImage defines
compareTo(BackupManifest$BackupImage) and uses Object.equals() At
BackupManifest.java:Object.equals() At BackupManifest.java:[lines 216-220] |
| | Class org.apache.hadoop.hbase.backup.impl.BackupStatus defines
non-transient non-serializable instance field table In
BackupStatus.java:instance field table In BackupStatus.java |
| | Dead store to lastBackup in
org.apache.hadoop.hbase.backup.impl.BackupSystemTable.readLogTimestampMap() At
BackupSystemTable.java:org.apache.hadoop.hbase.backup.impl.BackupSystemTable.readLogTimestampMap()
At BackupSystemTable.java:[line 381] |
| |
org.apache.hadoop.hbase.backup.impl.BackupUtil.getRSLogTimestampMins(HashMap)
makes inefficient use of keySet iterator instead of entrySet iterator At
BackupUtil.java:keySet iterator instead of entrySet iterator At
BackupUtil.java:[line 105] |
| |
org.apache.hadoop.hbase.backup.impl.BackupUtil$BackupCompleteData.compareTo(BackupUtil$BackupCompleteData)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead At BackupUtil.java:constructor; use Long.valueOf(String) instead At
BackupUtil.java:[line 372] |
| | org.apache.hadoop.hbase.backup.impl.BackupUtil$BackupCompleteData defines
compareTo(BackupUtil$BackupCompleteData) and uses Object.equals() At
BackupUtil.java:Object.equals() At BackupUtil.java:[lines 372-376] |
| | Boxed value is unboxed and then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:then
immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:[line 222] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At
IncrementalBackupManager.java:org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:[line 249] |
| | Boxed value is unboxed and then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter.accept(Path)
At IncrementalBackupManager.java:then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter.accept(Path)
At IncrementalBackupManager.java:[line 295] |
| | Should
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter be
a _static_ inner class? At IncrementalBackupManager.java:inner class? At
IncrementalBackupManager.java:[lines 274-298] |
| | Call to org.apache.hadoop.hbase.TableName.equals(String) in
org.apache.hadoop.hbase.backup.impl.RestoreUtil.restoreTableAndCreate(TableName,
TableName, Path, boolean) At RestoreUtil.java:TableName, Path, boolean) At
RestoreUtil.java:[line 107] |
| | Potentially ambiguous invocation of either an outer or inherited method
org.apache.hadoop.conf.Configured.getConf() in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$BackupDistCp.execute()
At MapReduceBackupCopyService.java:an outer or inherited method
org.apache.hadoop.conf.Configured.getConf() in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$BackupDistCp.execute()
At MapReduceBackupCopyService.java:[line 164] |
| | Should
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$SnapshotCopy
be a _static_ inner class? At MapReduceBackupCopyService.java:inner class?
At MapReduceBackupCopyService.java:[lines 105-116] |
| JDK v1.8.0 Failed junit tests |
hadoop.hbase.io.hfile.TestHFileBackedByBucketCache |
| | hadoop.hbase.io.hfile.TestHFileBackedByBucketCache |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12791394/HBASE-14030-v37.patch
|
| JIRA Issue | HBASE-14030 |
| Optional Tests | asflicense shellcheck javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7dabcf2 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-checkstyle-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/new-findbugs-hbase-server.html
|
| javadoc | root-jdk1.8.0:
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.8.0.txt
|
| javadoc | hbase-server-jdk1.8.0:
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt
|
| javadoc | root-jdk1.7.0_79:
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.7.0_79.txt
|
| javadoc | hbase-server-jdk1.7.0_79:
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_79.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/patch-unit-root-jdk1.8.0.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/patch-unit-root-jdk1.8.0.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/829/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
|
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/testReport/ |
| modules | C: . hbase-common hbase-protocol hbase-server U: . |
| Max memory used | 209MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/829/console |
This message was automatically generated.
> HBase Backup/Restore Phase 1
> ----------------------------
>
> Key: HBASE-14030
> URL: https://issues.apache.org/jira/browse/HBASE-14030
> Project: HBase
> Issue Type: Umbrella
> Affects Versions: 2.0.0
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-14030-v0.patch, HBASE-14030-v1.patch,
> HBASE-14030-v10.patch, HBASE-14030-v11.patch, HBASE-14030-v12.patch,
> HBASE-14030-v13.patch, HBASE-14030-v14.patch, HBASE-14030-v15.patch,
> HBASE-14030-v17.patch, HBASE-14030-v18.patch, HBASE-14030-v2.patch,
> HBASE-14030-v20.patch, HBASE-14030-v21.patch, HBASE-14030-v22.patch,
> HBASE-14030-v23.patch, HBASE-14030-v24.patch, HBASE-14030-v25.patch,
> HBASE-14030-v26.patch, HBASE-14030-v27.patch, HBASE-14030-v28.patch,
> HBASE-14030-v3.patch, HBASE-14030-v30.patch, HBASE-14030-v35.patch,
> HBASE-14030-v37.patch, HBASE-14030-v4.patch, HBASE-14030-v5.patch,
> HBASE-14030-v6.patch, HBASE-14030-v7.patch, HBASE-14030-v8.patch,
> hbase-14030_v36.patch
>
>
> This is the umbrella ticket for Backup/Restore Phase 1. See HBASE-7912 design
> doc for the phase description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
