[
https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148877#comment-13148877
]
Ted Yu commented on HBASE-4776:
-------------------------------
The above call is needed because the following is called prior to checking
closed flag:
{code}
HLog.Writer nextWriter = this.createWriterInstance(fs, newPath, conf);
{code}
This change would activate preLogRoll() and postLogRoll() for listeners.
Previously listeners wouldn't have been notified if closed is true upon
entering rollWriter().
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked
> inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
