[
https://issues.apache.org/jira/browse/HBASE-15336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180630#comment-15180630
]
Ted Yu commented on HBASE-15336:
--------------------------------
{code}
135 def createTable() {
136 if (catalog.numReg > 3) {
{code}
I don't see else branch for the above. Should we at least log in the else
branch ?
{code}
149 val startKey = Bytes.toBytes("aaaaaaa");
150 val endKey = Bytes.toBytes("zzzzzzz");
{code}
Why are start and end keys fixed ?
{code}
154 while(r == null || r.size() == 0) {
155 logDebug(s"region not allocated")
156 Thread.sleep(1000)
{code}
Should the above wait be guarded by timeout ?
{code}
161 admin.close()
162 connection.close()
{code}
Please close the above in finally block.
RegionLocator extends Closeable. Please close RegionLocator as well.
40
//Bytes.toBytes(input.asInstanceOf[String])//input.asInstanceOf[UTF8String].getBytes
Drop the above.
> Support Dataframe writer to the connector
> -----------------------------------------
>
> Key: HBASE-15336
> URL: https://issues.apache.org/jira/browse/HBASE-15336
> Project: HBase
> Issue Type: Sub-task
> Reporter: Zhan Zhang
> Assignee: Zhan Zhang
> Attachments: HBASE-15336-1.patch
>
>
> Currently, the connector only support read path. A complete solution should
> support both read and writer. This subtask add write support.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
