[
https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188378#comment-15188378
]
Heng Chen edited comment on HBASE-15406 at 3/10/16 12:32 AM:
-------------------------------------------------------------
{quote}
The exception message doesn't match the condition. Did you mean to say 'has to
be acquired" ?
{quote}
Sorry, it is confused. I should rename the "lease" to be "lock". My
original thought is before change switch, if we found there is one lock on it,
the action will be refused.
And the condition should be ">0"
{quote}
SplitOrMergeLeaseTracker does the rollback. What if master crashes after
getting zookeeper notification but before restoring split / merge states ?
{quote}
That is a problem, we can do cleanup when master start up.
was (Author: chenheng):
{quote}
The exception message doesn't match the condition. Did you mean to say 'has to
be acquired" ?
{quote}
Sorry, it is confused. I should rename the "lease" to be "lock". My
original thought is before change switch, if we found there is one lock on it,
the action will be refused.
{quote}
SplitOrMergeLeaseTracker does the rollback. What if master crashes after
getting zookeeper notification but before restoring split / merge states ?
{quote}
That is a problem, we can do cleanup when master start up.
> Split / merge switch left disabled after early termination of hbck
> ------------------------------------------------------------------
>
> Key: HBASE-15406
> URL: https://issues.apache.org/jira/browse/HBASE-15406
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-15406.v1.patch, wip.patch
>
>
> This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday:
> Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster
> Terminate hbck early
> Enter hbase shell where I observed:
> {code}
> hbase(main):001:0> splitormerge_enabled 'SPLIT'
> false
> 0 row(s) in 0.3280 seconds
> hbase(main):002:0> splitormerge_enabled 'MERGE'
> false
> 0 row(s) in 0.0070 seconds
> {code}
> Expectation is that the split / merge switches should be restored to default
> value after hbck exits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
