[
https://issues.apache.org/jira/browse/HBASE-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192699#comment-15192699
]
Yu Li commented on HBASE-15265:
-------------------------------
[~Apache9]
Good progress and great work sir!
bq. I think multiwal should not act as a 'WALProvider' in config, instead, it
should be an option.
FWIW, instead of supplying a new provider, it's more natural as a new WAL
implementation? Currently although we have abstract WAL as an interface,
there's no configuration to choose the WAL type. Let {{WALProvider}} specify
how we provide WALs (server-based DefaultWALProvider or region-based
RegionGroupingProvider) and {{WAL}} specify which type of WAL we're using (sync
or async), maybe this is more clear?
bq. Not that hard, but as discussed in HBASE-14949, it is not safe to
integration this feature into branch-1? User should first upgrade to a version
that contains HBASE-14949, then they can do rolling upgrade to enable
AsyncFSWAL.
At a glance of HBASE-14949 and comments there, it seems multiwal will have some
problem with the patch? But checking UT result only
TestReplicationEndpointWithMultipleWAL failed with jdk8 and all others passed,
mind help clarify what problem there might be? And could rolling-upgrade work
while "first upgrade to a version contains HBASE-14949" and to use async FSHLog
we only need a two-steps rolling-upgrade?
Since 1.x is our current stable release branch and I believe this work will
benefit a lot for write latency, I'd like to give async wal an early try when
it completes. Not sure but there might be more work if we make it compatible
with multiple WAL (asking because we already using multiwal online)? Let me
know if anything I could help to complete the work for multiwal. Thanks.
> Implement an asynchronous FSHLog
> --------------------------------
>
> Key: HBASE-15265
> URL: https://issues.apache.org/jira/browse/HBASE-15265
> Project: HBase
> Issue Type: Sub-task
> Components: wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-15265-v1.patch, HBASE-15265-v2.patch,
> HBASE-15265-v3.patch, HBASE-15265-v4.patch, HBASE-15265-v5.patch,
> HBASE-15265-v6.patch, HBASE-15265-v7.patch, HBASE-15265.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
