[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201516#comment-15201516 ]
Heng Chen commented on HBASE-15406: ----------------------------------- {quote} Can you identify the users in steps 1 and 3 above ? Are they different users ? {quote} Is there any difference whether they are the same user? we can't protect our switch be changed without lock. {quote} There is lock mechanism in place to prevent two hbck instances from running at the same time. You don't need to add extra code covering this. {quote} But as you said above, if the hbck can't run at the same time, current patch v1 will has no problem, right? > Split / merge switch left disabled after early termination of hbck > ------------------------------------------------------------------ > > Key: HBASE-15406 > URL: https://issues.apache.org/jira/browse/HBASE-15406 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15406.patch, HBASE-15406.v1.patch, > HBASE-15406_v1.patch, test.patch, wip.patch > > > This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday: > Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster > Terminate hbck early > Enter hbase shell where I observed: > {code} > hbase(main):001:0> splitormerge_enabled 'SPLIT' > false > 0 row(s) in 0.3280 seconds > hbase(main):002:0> splitormerge_enabled 'MERGE' > false > 0 row(s) in 0.0070 seconds > {code} > Expectation is that the split / merge switches should be restored to default > value after hbck exits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)