[ 
https://issues.apache.org/jira/browse/HBASE-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150236#comment-13150236
 ] 

stack commented on HBASE-4785:
------------------------------

clearCachedLocationForServer javadoc has two params but method only takes one.  
Can fix on commit.

This could just be a Map?

{code}
for (SoftValueSortedMap<byte[], HRegionLocation> tableLocations
{code}

...rather thana SoftValueSortedMap... or a NavigableMap or SortedMap?  No 
biggie.

+1 on patch and for 0.92.  Why the failures above though?   A bunch of stuff 
failed.  Oh.... funny:

{code}
java.lang.RuntimeException: Not implemented
        at 
org.apache.hadoop.hbase.util.SoftValueSortedMap.entrySet(SoftValueSortedMap.java:175)
{code}

Looks like your patch is missing a piece Nicolas.
                
> Improve recovery time of HBase client when a region server dies.
> ----------------------------------------------------------------
>
>                 Key: HBASE-4785
>                 URL: https://issues.apache.org/jira/browse/HBASE-4785
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4785.patch
>
>
> When a region server dies, the HBase client waits until the RPC timesout 
> before learning that it needs to check META to find the new location of the 
> region. And it incurs this *timeout* cost for every region being served by 
> the dead region server. Remove this overhead by clearing the entries in cache 
> that have the dead region server as their values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to