[ 
https://issues.apache.org/jira/browse/HBASE-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209302#comment-15209302
 ] 

Ted Yu commented on HBASE-15515:
--------------------------------

{code}
+     * Returns a least loaded server which have better locality for this region
+     * than the current server.
{code}
which have -> which has
Is it possible to add test for the issues described above ?

> Improve LocalityBasedCandidateGenerator in Balancer
> ---------------------------------------------------
>
>                 Key: HBASE-15515
>                 URL: https://issues.apache.org/jira/browse/HBASE-15515
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15515-v1.patch, HBASE-15515.patch
>
>
> There are some problems which need to fix.
> 1. LocalityBasedCandidateGenerator.getLowestLocalityRegionOnServer should 
> skip empty region.
> 2. When use LocalityBasedCandidateGenerator to generate Cluster.Action, it 
> should add random operation instead of pickLowestLocalityServer(cluster). 
> Because the search function may stuck here if it always generate the same 
> Cluster.Action.
> 3. getLeastLoadedTopServerForRegion should get least loaded server which have 
> better locality than current server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to