[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209640#comment-15209640
]
Ted Yu edited comment on HBASE-15411 at 3/24/16 3:29 AM:
---------------------------------------------------------
One comment is for not going through Connection when doing snapshot.
Here is code from MasterRpcServices#snapshot() :
{code}
master.snapshotManager.takeSnapshot(snapshot);
{code}
One option is for HMaster to pass snapshotManager to FullTableBackupProcedure.
But this won't work because FullTableBackupProcedure#executeFromState() may
stop anywhere.
After which:
{code}
public FullTableBackupProcedure() {
// Required by the Procedure framework to create the procedure on replay
{code}
Meaning we should be prepared that full back continue from any state.
Suggestion for other approach is welcome.
was (Author: [email protected]):
One comment is for not going through Connection when doing snapshot.
Here is code from MasterRpcServices#snapshot() :
{code}
master.snapshotManager.takeSnapshot(snapshot);
{code}
Option is for HMaster to pass snapshotManager to FullTableBackupProcedure.
I want to confirm this is acceptable.
Otherwise, suggestion for other approach is welcome.
> Rewrite backup with Procedure V2
> --------------------------------
>
> Key: HBASE-15411
> URL: https://issues.apache.org/jira/browse/HBASE-15411
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 15411-v1.txt, 15411-v11.txt, 15411-v12.txt,
> 15411-v13.txt, 15411-v14.txt, 15411-v15.txt, 15411-v16.txt, 15411-v18.txt,
> 15411-v22.txt, 15411-v3.txt, 15411-v5.txt, 15411-v6.txt, 15411-v7.txt,
> 15411-v9.txt, FullTableBackupProcedure.java
>
>
> Currently full / incremental backup is driven by BackupHandler (see call()
> method for flow).
> This issue is to rewrite the flow using Procedure V2.
> States (enum) for full / incremental backup would be introduced in
> Backup.proto which correspond to the steps performed in BackupHandler#call().
> executeFromState() would pace the backup based on the current state.
> serializeStateData() / deserializeStateData() would be used to persist state
> into procedure WAL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
