[ 
https://issues.apache.org/jira/browse/HBASE-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216050#comment-15216050
 ] 

stack commented on HBASE-15362:
-------------------------------

On the patch, I think the original code is wrong where it creates a 
Configuration on construction of an Algorithm and then takes a Configuration 
when you ask for a Codec. We should get rid of the first instance. Would be 
good too if we could avoid mention of explicit HBaseConfiguration in here so 
the Compressor is more portable.... Need to spend more than five minutes 
looking at this. Thanks [~dvdreddy]

> Compression Algorithm does not respect config params from hbase-site
> --------------------------------------------------------------------
>
>                 Key: HBASE-15362
>                 URL: https://issues.apache.org/jira/browse/HBASE-15362
>             Project: HBase
>          Issue Type: Bug
>            Reporter: deepankar
>            Assignee: deepankar
>            Priority: Trivial
>         Attachments: HBASE-15362.patch
>
>
> Compression creates conf using new Configuration() and this leads to it not 
> respecting the confs set in hbase-site, fixing it is trivial using 
> HBaseConfiguration.create()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to