[ 
https://issues.apache.org/jira/browse/HBASE-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218530#comment-15218530
 ] 

Vladimir Rodionov commented on HBASE-15509:
-------------------------------------------

{quote}
HFileContext is meant to be immutable. You add methods that do get/set.
{quote}
Any other way to pass configuration to HFileBlock.Writer?
{quote}
We add new configs for that non-existent 'expert hbase user' to twiddle: 
"hbase.hfile.write.buffer-reuse.max.size" The on/off switch is fine but this 
new 'sizing' with no means of measuring if an arbitrary setting is improving 
things or making them worse.
{quote}

I do not mind if we make default and no config options will be required.



> Avoid copy of block data in HFileBlock$Writer.finishBlock
> ---------------------------------------------------------
>
>                 Key: HBASE-15509
>                 URL: https://issues.apache.org/jira/browse/HBASE-15509
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>         Attachments: HBASE-15509-v1.patch, HBASE-15509-v2.patch
>
>
> This calls ByteArrayOutputStream.toByteArray() which creates a copy of data 
> block. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to