[
https://issues.apache.org/jira/browse/HBASE-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220720#comment-15220720
]
Ted Yu commented on HBASE-15485:
--------------------------------
lgtm
{code}
233 * @return true when a mid-row result is formed.
234 */
235 boolean betweenCellsResultFormed() {
{code}
Why not naming the method midRowResultFormed ?
'Between cells' can happen inter row :-)
> Filter.reset() should not be called between batches
> ---------------------------------------------------
>
> Key: HBASE-15485
> URL: https://issues.apache.org/jira/browse/HBASE-15485
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Phil Yang
> Assignee: Phil Yang
> Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.5, 1.2.2
>
> Attachments: HBASE-15485-branch-1-v2.patch,
> HBASE-15485-branch-1.1-v1.patch, HBASE-15485-branch-1.patch,
> HBASE-15485-v1.patch, HBASE-15485-v2.patch, HBASE-15485-v3.patch,
> HBASE-15485-v4.patch
>
>
> As discussed in HBASE-15325, now we will resetFilters if partial result not
> formed, but we should not reset filters when batch limit reached
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
