[ https://issues.apache.org/jira/browse/HBASE-15505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220765#comment-15220765 ]
Enis Soztutar commented on HBASE-15505: --------------------------------------- Thanks Gabor for the patch. +1 for the patch. bq. Could you point the other classes to test against? Thanks I do not have the list, but I was thinking to go over all of the classes that are marked with InterfaceAudience.Public, and if they are POJO-style classes (like HTD, ReplicationPeerConfig, etc) change them to be builder style. Maybe we have already covered everything. > ReplicationPeerConfig should be builder-style > --------------------------------------------- > > Key: HBASE-15505 > URL: https://issues.apache.org/jira/browse/HBASE-15505 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Labels: beginner, beginners > Fix For: 2.0.0 > > Attachments: HBASE-15505.1.patch > > > Similar to HTD, HCD, {{ReplicationPeerConfig}} should be builder-style: > {code} > ReplicationPeerConfig().setFoo(foo).setBar(bar); > {code} > See {{TestHTableDescriptor.testClassMethodsAreBuilderStyle()}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)