[
https://issues.apache.org/jira/browse/HBASE-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234243#comment-15234243
]
Jerry He commented on HBASE-15591:
----------------------------------
ok. I see what is going on with the Checkstyle:
{noformat}
./hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java:213:
long wait =: error: 'if' child have incorrect indentation level 10,
expected level should be 12.
./hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java:213:
long wait =: error: 'member def type' have incorrect indentation
level 10, expected level should be 12.
./hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java:216:
wait = wait / 10;: error: 'if' child have incorrect indentation level
10, expected level should be 12.
./hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java:217:
Thread.sleep(wait);: error: 'if' child have incorrect indentation
level 10, expected level should be 12.
./hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java:217:
Thread.sleep(wait);: error: 'method call' child have incorrect
indentation level 10, expected level should be 12.
{noformat}
In the existing code:
{code}
try {
switch (state) {
case SERVER_CRASH_START:
...
case SERVER_CRASH_GET_REGIONS:
...
}
{code}
The right fix is to move the whole block within the switch 2 spaces to the
right.
But it will make the current patch bulky and confusing.
Let's commit v3. Then fix the indentation of the entire block in a separate
commit.
> ServerCrashProcedure not yielding
> ---------------------------------
>
> Key: HBASE-15591
> URL: https://issues.apache.org/jira/browse/HBASE-15591
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 1.2.0
> Reporter: Jerry He
> Assignee: Jerry He
> Attachments: HBASE-15591-master-v2.patch,
> HBASE-15591-master-v3.patch, HBASE-15591.patch
>
>
> ServerCrashProcedure is not propagating ProcedureYieldException to the
> ProcedureExecutor
> One symptom is that while ServerCrashProcedure is waiting for meta to be up
> the Procedure WALs get filled up rapidly with all the executions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
