[ https://issues.apache.org/jira/browse/HBASE-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237837#comment-15237837 ]
Phil Yang commented on HBASE-15593: ----------------------------------- The timeout's unit is ms and we need some comments/doc here. This config is a protection like hbase.region.server.rpc.minimum.scan.time.limit.delta in RSRpcServices to prevent regarding this request as timeout immediately. It may not be necessary now because in scan heartbeat we have hbase.region.server.rpc.minimum.scan.time.limit.delta already, but it may be useful when we use it in other scsenes. Thanks. > Time limit of scanning should be offered by client > -------------------------------------------------- > > Key: HBASE-15593 > URL: https://issues.apache.org/jira/browse/HBASE-15593 > Project: HBase > Issue Type: Bug > Affects Versions: 1.2.0, 1.1.4 > Reporter: Phil Yang > Assignee: Phil Yang > Attachments: HBASE-15593-v1.patch, HBASE-15593-v2.patch, > HBASE-15593-v3.patch > > > In RSRpcServices.scan, we will set a time limit equaling to > Math.min(scannerLeaseTimeoutPeriod, rpcTimeout) / 2, and will response > heartbeat message if we reach this limit. However, two timeout settings > (hbase.client.scanner.timeout.period and hbase.rpc.timeout) are read from > RS's configure, which may be different from client's. If client's setting is > much less than server's, there may still be timeout at client side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)