[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238343#comment-15238343
]
Sergey Soldatov commented on HBASE-15638:
-----------------------------------------
[~stack] What is the reason to do it in this way? IMHO it's better to apply the
shading pattern to all required modules
Let's say we have modules:
external ModuleA which is suppose to be shaded. (Protobuf)
ModuleB depends on ModuleA (protocols)
ModuleC depends on ModuleB and directly uses some classes from ModuleA (Client)
So, we add ModuleA to the direct dependencies of ModuleC (so it will depends on
both ModuleB and ModuleA and it doesn't matter whether we have jar for ModuleB
shaded or not)
And when we build ModuleB and ModuleC we apply the same shading pattern
"ModuleA->shaded.ModuleA".
That will resolve the problem with ByteString and no need for changing imports.
> Shade protobuf
> --------------
>
> Key: HBASE-15638
> URL: https://issues.apache.org/jira/browse/HBASE-15638
> Project: HBase
> Issue Type: Bug
> Components: Protobufs
> Reporter: stack
> Attachments: as.far.as.server.patch
>
>
> Shade protobufs so we can move to a different version without breaking the
> world. We want to get up on pb3 because it has unsafe methods that allow us
> save on copies; it also has some means of dealing with BBs so we can pass it
> offheap DBBs. We'll probably want to change PB3 to open it up some more too
> so we can stay offheap as we traverse PB. This issue comes of [~anoop.hbase]
> and [~ram_krish]'s offheaping of the readpath work.
> This change is mostly straight-forward but there are some tricky bits:
> # How to interface with HDFS? It wants its ByteStrings. Here in particular
> in FanOutOneBlockAsyncDFSOutputSaslHelper:
> {code}
> if (payload != null) {
> builder.setPayload(ByteString.copyFrom(payload));
> }
> {code}
> # [~busbey] also points out that we need to take care of endpoints done as
> pb. Test at least.
> Let me raise this one on the dev list too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
