[ 
https://issues.apache.org/jira/browse/HBASE-15187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242035#comment-15242035
 ] 

Jerry He commented on HBASE-15187:
----------------------------------

Hi, [~tedyu]

You put the property hbase.rest-csrf.browser-useragents-regex in the 
hbase-default.xml.  But not any of the other new configuration properties, 
including the one that enables this feature.
We probably should keep that property out of hbase-default.xml as well?

Also there is a risk that we will be out of sync with the Hadoop CSRF filter, 
e.g. they fix a bug or make an improvement (it already happened in between your 
patches).  Can you add a note or a pointer in the Release Note so that people 
are aware and are clear?

+1 after the above.

> Integrate CSRF prevention filter to REST gateway
> ------------------------------------------------
>
>                 Key: HBASE-15187
>                 URL: https://issues.apache.org/jira/browse/HBASE-15187
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>              Labels: rest
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15187-branch-1.v13.patch, HBASE-15187.v1.patch, 
> HBASE-15187.v10.patch, HBASE-15187.v10.patch, HBASE-15187.v11.patch, 
> HBASE-15187.v12.patch, HBASE-15187.v13.patch, HBASE-15187.v2.patch, 
> HBASE-15187.v3.patch, HBASE-15187.v4.patch, HBASE-15187.v5.patch, 
> HBASE-15187.v6.patch, HBASE-15187.v7.patch, HBASE-15187.v8.patch, 
> HBASE-15187.v9.patch
>
>
> HADOOP-12691 introduced a filter in Hadoop Common to help REST APIs guard 
> against cross-site request forgery attacks.
> This issue tracks the integration of that filter into HBase REST gateway.
> From REST section of refguide:
> To delete a table, use a DELETE request with the /schema endpoint:
> http://example.com:8000<table>/schema
> Suppose an attacker hosts a malicious web form on a domain under his control. 
> The form uses the DELETE action targeting a REST URL. Through social 
> engineering, the attacker tricks an authenticated user into accessing the 
> form and submitting it.
> The browser sends the HTTP DELETE request to the REST gateway.
> At REST gateway, the call is executed and user table is dropped



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to