[ https://issues.apache.org/jira/browse/HBASE-15665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247693#comment-15247693 ]
Sean Busbey commented on HBASE-15665: ------------------------------------- {quote} For 0.98, the fingbugs and javadoc issues are not related, I have checked already. Sean Busbey Any ideas that why pre commit always report findbugs and javadoc issue for 0.98? {quote} Those are the reports for the state of the branch prior to the patch being applied. Those issues exist in the 0.98 branch, so they continue to show up. This is the part that talks about after the patch: {quote} +1 findbugs 4m 21s the patch passed -1 javadoc 1m 33s hbase-server in the patch failed with JDK v1.8.0. +1 javadoc 0m 40s the patch passed with JDK v1.7.0_79 {quote} The failure of javadoc under jdk1.8 is real, but since it failed prior to the patch it's hard to know if the patch makes things better or worse. AFAIK we have never done a jdk8 compatibility pass on that branch. > Support using different StoreFileComparators for different CompactionPolicies > ----------------------------------------------------------------------------- > > Key: HBASE-15665 > URL: https://issues.apache.org/jira/browse/HBASE-15665 > Project: HBase > Issue Type: Sub-task > Components: Compaction > Affects Versions: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0 > > Attachments: HBASE-15665-0.98.patch, HBASE-15665-branch-1.patch, > HBASE-15665.patch > > > Now for DateTieredCompactionPolicy, if we output multiple files when > compaction, we will use the same max sequence id for all the output files(see > HBASE-15389 for more details). So we need to sort the store files by > timestamp if they have the same max sequence id which is different from the > original store file comparator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)