[
https://issues.apache.org/jira/browse/HBASE-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151847#comment-13151847
]
Phabricator commented on HBASE-4809:
------------------------------------
nspiegelberg has commented on the revision "[jira] [HBASE-4809] Per-CF set RPC
metrics".
lgtm for the most part. pretty straightforward
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java:220-222
any reason why this isn't in TestHeapSize? so other classes work this way?
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:534-535
nit pick: isEmpty() is guaranteed O(1). size() is not and may be O(n)
depending on the container. That said, I'm pretty sure that it's O(1) in this
case and too many other things are CPU intensive, so I consider it an optional
change.
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:547
for accuracy, should this condition be:
MAX_SIZE -= "__more".length()
if (sb.length() + Bytes.toString(family).length() > MAX_SIZE)
right now, it's not really a MAX_SIZE, it's more TRUNCATE_AFTER
REVISION DETAIL
https://reviews.facebook.net/D483
> Per-CF set RPC metrics
> ----------------------
>
> Key: HBASE-4809
> URL: https://issues.apache.org/jira/browse/HBASE-4809
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D483.1.patch
>
>
> Porting per-CF set metrics for RPC times and response sizes from 0.89-fb to
> trunk. For each "mutation signature" (a set of column families involved in an
> RPC request) we increment several metrics, allowing to monitor access
> patterns. We deal with guarding against an explosion of the number of
> metrics in HBASE-4638 (which might even be implemented as part of this JIRA).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
