[
https://issues.apache.org/jira/browse/HBASE-15381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250945#comment-15250945
]
Ted Yu commented on HBASE-15381:
--------------------------------
{code}
+ } catch (IOException e) {
+ LOG.error("Failed to perform the mob compaction", e);
{code}
The IOE is swallowed ?
{code}
+ } catch (IOException e) {
+ LOG.error("Failed to mark end of mob compation", e);
{code}
Include table name in message.
For doCompaction() :
{code}
+ boolean isAllFiles = dispatchMobCompaction(tableName, column,
allFiles);
{code}
isAllFiles has slightly different meaning from allFiles. Consider renaming it
to make the code easier to understand.
{code}
+ } catch (Exception e) {
{code}
Catching IOE is not enough ?
{code}
+ if (hri.isOffline() && (hri.isSplit() || hri.isSplitParent())) {
+ allRegionsOnline = false;
{code}
Checking hri.isOffline() is not enough ?
> Implement a distributed MOB compaction by procedure
> ---------------------------------------------------
>
> Key: HBASE-15381
> URL: https://issues.apache.org/jira/browse/HBASE-15381
> Project: HBase
> Issue Type: Improvement
> Components: mob
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HBASE-15381.patch, mob distributed compaction
> design-v2.pdf, mob distributed compaction design.pdf
>
>
> In MOB, there is a periodical compaction which runs in HMaster (It can be
> disabled by configuration), some small mob files are merged into bigger ones.
> Now the compaction only runs in HMaster which is not efficient and might
> impact the running of HMaster. In this JIRA, a distributed MOB compaction is
> introduced, it is triggered by HMaster, but all the compaction jobs are
> distributed to HRegionServers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
