[
https://issues.apache.org/jira/browse/HBASE-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252914#comment-15252914
]
Hudson commented on HBASE-15366:
--------------------------------
SUCCESS: Integrated in HBase-1.4 #109 (See
[https://builds.apache.org/job/HBase-1.4/109/])
HBASE-15366 Add doc, trace-level logging, and test around No change in (stack:
rev 0b65f2002bbdabd699ce12598b1179d1f2d7f1c7)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockCompatibility.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOrOperatorWithBlkCnt.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
> Add doc, trace-level logging, and test around hfileblock
> --------------------------------------------------------
>
> Key: HBASE-15366
> URL: https://issues.apache.org/jira/browse/HBASE-15366
> Project: HBase
> Issue Type: Sub-task
> Components: BlockCache
> Affects Versions: 2.0.0
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: 15355.backport.branch-1.v2.patch,
> 15366.branch-1.backport.patch, 15366.patch, 15366v2.patch, 15366v3.patch,
> 15366v4.patch, 15366v4.patch
>
>
> What hfileblock is doing -- that it overreads when pulling in from hdfs to
> fetch the header of the next block to save on seeks; that it caches the block
> and overread and then adds an extra 13 bytes to the cached entry; that
> buckets in bucketcache have at least four hfileblocks in them and so on --
> was totally baffling me. This patch docs the class, adds some trace-level
> logging so you can see if you are doing the right thing, and then adds a test
> of file-backed bucketcache that checks that persistence is working.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
