[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-15693:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to all branches. Thanks all for reviewing.
Will check the jenkins checkstyle result to see if it breaks something.
> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
> Key: HBASE-15693
> URL: https://issues.apache.org/jira/browse/HBASE-15693
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.19, 1.4.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: checkstyle
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2, 0.98.20
>
> Attachments: HBASE-15693-0.98.patch, HBASE-15693-branch-1.0.patch,
> HBASE-15693-branch-1.1.patch, HBASE-15693-branch-1.2.patch,
> HBASE-15693-branch-1.3.patch, HBASE-15693-branch-1.patch, HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle
> warnings in the pre commit result. And I haven't found any developer guide
> which tells me what is the right order so this time I decided to read the
> rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which
> can only work with option 'top' or 'bottom'(which means place static imports
> on top or bottom) and use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to
> 'top'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
