[
https://issues.apache.org/jira/browse/HBASE-15477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-15477:
--------------------------
Attachment: 15477.backport.branch-1.v7.patch
This patch removes support for hfileblock v1 -- i.e. blocks from < 0.92 hfile
v1s -- so tests for migration from v1 to v2 and from 0.92 to 0.96 which have
been deprecated and supposed to have been removed post 0.96 failed.
Posting a patch that removes the deprecated tests as part of this patch. Will
open new issue for the backport to highlight what I'm doing in here.
> Do not save 'next block header' when we cache hfileblocks
> ---------------------------------------------------------
>
> Key: HBASE-15477
> URL: https://issues.apache.org/jira/browse/HBASE-15477
> Project: HBase
> Issue Type: Sub-task
> Components: BlockCache, Performance
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 15366v4.patch, 15477.backport.branch-1.patch,
> 15477.backport.branch-1.v2.patch, 15477.backport.branch-1.v3.patch,
> 15477.backport.branch-1.v4.patch, 15477.backport.branch-1.v4.patch,
> 15477.backport.branch-1.v5.patch, 15477.backport.branch-1.v5.patch,
> 15477.backport.branch-1.v6.patch, 15477.backport.branch-1.v7.patch,
> 15477.patch, 15477v2.patch, 15477v3.patch, 15477v3.patch, 15477v4.patch
>
>
> When we read from HDFS, we overread to pick up the next blocks header.
> Doing this saves a seek as we move through the hfile; we save having to
> do an explicit seek just to read the block header every time we need to
> read the body. We used to read in the next header as part of the
> current blocks buffer. This buffer was then what got persisted to
> blockcache; so we were over-persisting wrtiting out our block plus the
> next blocks' header (overpersisting 33 bytes). Parse of HFileBlock
> complicated by this extra tail. Fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
