[ 
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258689#comment-15258689
 ] 

stack commented on HBASE-14920:
-------------------------------

Unused import import static 
org.apache.hadoop.hbase.io.hfile.BlockType.MAGIC_LENGTH;

Was IntegrationTestBigLinkedList failing w/o your changing the flush policy to 
ALL?

Misedit hiere...    * @g MemStore#snapshot()

No need of a region lock in this case:

{code}
47       * Periodically, a compaction is applied in the background to all 
pipeline components resulting
48       * in a single read-only component. The ``old'' components are 
discarded when no scanner is reading
49       * them.
{code}

We will print this out for every Store in the table?

92          LOG.info("Setting in-memory flush size threshold for table "
93              + getRegionServices().getRegionInfo().getTable()
94              + "to " + flushSizeLowerBound);

Should it not be a message particular to this Store rather than a remark on 
table?

These look like internal utility methods but are public:

  public static long getSegmentSize(Segment segment) {
  public static long getSegmentsSize(List<? extends Segment> list) {

More to follow...



> Compacting Memstore
> -------------------
>
>                 Key: HBASE-14920
>                 URL: https://issues.apache.org/jira/browse/HBASE-14920
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-14920-V01.patch, HBASE-14920-V02.patch, 
> HBASE-14920-V03.patch, HBASE-14920-V04.patch, move.to.junit4.patch
>
>
> Implementation of a new compacting memstore with non-optimized immutable 
> segment representation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to