[
https://issues.apache.org/jira/browse/HBASE-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152555#comment-13152555
]
Hadoop QA commented on HBASE-4805:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504136/4805-v5.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -163 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 52 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestShell
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/285//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/285//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/285//console
This message is automatically generated.
> Allow better control of resource consumption in HTable
> ------------------------------------------------------
>
> Key: HBASE-4805
> URL: https://issues.apache.org/jira/browse/HBASE-4805
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4805-v2.txt, 4805-v3.txt, 4805-v4.txt, 4805-v5.txt,
> 4805.txt
>
>
> From some internal discussions at Salesforce we concluded that we need better
> control over the resources (mostly threads) consumed by HTable when used in a
> AppServer with many client threads.
> Since HTable is not thread safe, the only options are cache them (in a custom
> thread local or using HTablePool) or to create them on-demand.
> I propose a simple change: Add a new constructor to HTable that takes an
> optional ExecutorService and HConnection instance. That would make HTable a
> pretty lightweight object and we would manage the ES and HC separately.
> I'll upload a patch a soon to get some feedback.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
