[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265121#comment-15265121 ]
Hadoop QA commented on HBASE-15357: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for instructions. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s {color} | {color:red} HBASE-15357 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12801578/15357-branch-1.v3.txt | | JIRA Issue | HBASE-15357 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1692/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > TableInputFormatBase getSplitKey does not handle signed bytes correctly > ----------------------------------------------------------------------- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce > Reporter: Nathan Schile > Assignee: Nathan Schile > Fix For: 2.0.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)