[
https://issues.apache.org/jira/browse/HBASE-15784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273760#comment-15273760
]
Duo Zhang commented on HBASE-15784:
-----------------------------------
Yes, ThreadPoolExecutor only adds new threads when queue full if we already
have more threads than core pool size.
+1 on setting core pool size to a value same with max pool size.
And I suggest to set allowCoreThreadTimeOut to true. The patch only shows diff
so I'm not sure whether we set it at all places. Could you please verify it?
Thanks.
> MIsuse core/maxPoolSize of LinkedBlockingQueue in ThreadPoolExecutor
> --------------------------------------------------------------------
>
> Key: HBASE-15784
> URL: https://issues.apache.org/jira/browse/HBASE-15784
> Project: HBase
> Issue Type: Bug
> Components: Client, Replication, Thrift
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HBASE-15784.patch
>
>
> LinkedBlockingQueue is usually used in ThreadPoolExecutor. It allows the
> thread pool not to be blocked if the number of running threads in the pool is
> less than the max pool size and the queue is not full.
> But when the core pool size of ThreadPoolExecutor is different from the max
> pool size, the things don't go as expected. When the number of running
> threads is the same with the core size, more requests of executions are added
> into the LinkedBlockingQueue. And the requests can be executed again only
> when LinkedBlockingQueue is full or some of running threads are finished.
> Thus it is better to use the same value for the core and max pool size when
> the LinkedBlockingQueue is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
