[
https://issues.apache.org/jira/browse/HBASE-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274271#comment-15274271
]
Elliott Clark commented on HBASE-15771:
---------------------------------------
bq.We are explicitly exposing PB classes from this patch. Is this intentional,
or just that the corresponding pojo's are not implemented yet?
For the most part yeah. On cpp protobuf's are decently small. So using them as
the default storage makes sense. So I plan on using them whenever the api isn't
too unwieldy. However for requests and responses the protobuf api is so far
out there that I think a wrapping pojo will make things easier enough to
justify the added overhead.
bq.Also you seem to be favoring Client as the entry point versus Connection as
in the Java client's case. Having a "client" object to keep the cluster
connection is more intuitive, but it will be a deviation from our java API (not
that it is a show-stopper).
Yeah I was more going for simplicity. Since the entire client is thread safe it
doesn't make sense to have lots of lightweight objects around.
> Document all the public classes
> -------------------------------
>
> Key: HBASE-15771
> URL: https://issues.apache.org/jira/browse/HBASE-15771
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-15771.patch
>
>
> Add on doxygen comments for all public classes and methods.
> Once that's done then we can turn on doxygen with error on missing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
