[
https://issues.apache.org/jira/browse/HBASE-15778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275284#comment-15275284
]
Hudson commented on HBASE-15778:
--------------------------------
FAILURE: Integrated in HBase-Trunk_matrix #902 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/902/])
HBASE-15778 replace master.am and master.sm direct access with getter
(matteo.bertozzi: rev 99e2deb86ff2285e22800e55259033a791d4612d)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java
> replace master.am and master.sm direct access with getter calls
> ---------------------------------------------------------------
>
> Key: HBASE-15778
> URL: https://issues.apache.org/jira/browse/HBASE-15778
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 2.0.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-15778-v0.patch
>
>
> MasterRpcServices seems to access directly a bunch of members of HMaster. I
> think this is because when we split HMaster and MaterRpcServices we just did
> a find & replace.
> I was trying to mock and have a different AssignmentManager and ServerManager
> but it got impossible with those access directly.
> so, here a patch to avoid the direct access to AM and SM.
> There are many more members that can be made private but I'm lazy. so this
> pass is only AM, SM related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
