[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276249#comment-15276249
]
Sean Busbey commented on HBASE-15693:
-------------------------------------
{quote}
Sean Busbey Chris Nauroth is there a way we can add arbitrary mvn flags to a
yetus precommit build? In this case, I think precommit missed the breaking
change because -Prelease was not applied.
{quote}
Yep!
If you take a look at the 'personality_modules' function in our precommit
personality, it passes '-DHBasePatchProcess' to all tests and also
'-PrunAllTests' to the unit test plugin ([ref
1|https://github.com/apache/hbase/blob/e5d01577e4e989b1023559aa6addd1b37252293e/dev-support/hbase-personality.sh#L71],
[ref
2|https://github.com/apache/hbase/blob/e5d01577e4e989b1023559aa6addd1b37252293e/dev-support/hbase-personality.sh#L98]).
We could either send '-Prelease' for checkstyle similar to how we do the
unit-test-specific change, or we could send it to everything.
> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
> Key: HBASE-15693
> URL: https://issues.apache.org/jira/browse/HBASE-15693
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.19, 1.4.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: checkstyle
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.2.2, 0.98.20, 1.1.6
>
> Attachments: HBASE-15693-0.98.patch, HBASE-15693-branch-1.0.patch,
> HBASE-15693-branch-1.1.patch, HBASE-15693-branch-1.2.patch,
> HBASE-15693-branch-1.3.patch, HBASE-15693-branch-1.patch, HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle
> warnings in the pre commit result. And I haven't found any developer guide
> which tells me what is the right order so this time I decided to read the
> rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which
> can only work with option 'top' or 'bottom'(which means place static imports
> on top or bottom) and use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to
> 'top'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
