[ 
https://issues.apache.org/jira/browse/HBASE-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277723#comment-15277723
 ] 

ramkrishna.s.vasudevan commented on HBASE-15525:
------------------------------------------------

bq.Not a big deal and wont consume much more heap space. Bit more overhead but 
ok IMO.
Am not very sure.. One list may be enough. What ever you think anyway.
bq. That should not be done by the pool.
True.. So my point was that let this new class not be a Stream rather be 
something else like a factory or a BBGenerator which wil use this BbPool.  So 
if BBPool does not give a BB let it create a BB or what ever. Let that Bb be 
passed to BbOutputStream? Will that work?
Ya as this generator is creating the BB and knows how it got created this close 
and putting back to the pool can be done by that class. 


> OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts
> --------------------------------------------------------------------------
>
>                 Key: HBASE-15525
>                 URL: https://issues.apache.org/jira/browse/HBASE-15525
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC
>            Reporter: deepankar
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15525_V1.patch, HBASE-15525_V2.patch, 
> HBASE-15525_V3.patch, HBASE-15525_WIP.patch, WIP.patch
>
>
> After HBASE-13819 the system some times run out of direct memory whenever 
> there is some network congestion or some client side issues.
> This was because of pending RPCs in the RPCServer$Connection.responseQueue 
> and since all the responses in this queue hold a buffer for cellblock from 
> BoundedByteBufferPool this could takeup a lot of memory if the 
> BoundedByteBufferPool's moving average settles down towards a higher value 
> See the discussion here 
> [HBASE-13819-comment|https://issues.apache.org/jira/browse/HBASE-13819?focusedCommentId=15207822&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15207822]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to