[
https://issues.apache.org/jira/browse/HBASE-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284152#comment-15284152
]
Phil Yang commented on HBASE-15593:
-----------------------------------
We have applied this patch to production cluster(0.98) simultaneously with
porting all other features on scanning RPC chunking/heartbeat. Clients should
be upgraded to the new version to support new protocol, but not all users done
this work right now. So now we are still collecting information about scanning
chunking/heartbeat.
For this issue, I think it is ok to commit, because it is not a big
modification and I think it is a bugfix because users usually set their own
hbase.client.scanner.timeout.period, and a small timeout will result in the
heartbeat ineffective.
> Time limit of scanning should be offered by client
> --------------------------------------------------
>
> Key: HBASE-15593
> URL: https://issues.apache.org/jira/browse/HBASE-15593
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.1.4
> Reporter: Phil Yang
> Assignee: Phil Yang
> Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.2, 1.1.6
>
> Attachments: HBASE-15593-branch-1-v1.patch,
> HBASE-15593-branch-1-v2.patch, HBASE-15593-branch-1-v3.patch,
> HBASE-15593-branch-1.1-v1.patch, HBASE-15593-branch-1.1-v2.patch,
> HBASE-15593-branch-1.1-v3.patch, HBASE-15593-branch-1.2-v1.patch,
> HBASE-15593-branch-1.2-v2.patch, HBASE-15593-branch-1.2-v3.patch,
> HBASE-15593-v1.patch, HBASE-15593-v2.patch, HBASE-15593-v3.patch,
> HBASE-15593-v4.patch, HBASE-15593-v5.patch, HBASE-15593-v6.patch,
> HBASE-15593-v7.patch
>
>
> In RSRpcServices.scan, we will set a time limit equaling to
> Math.min(scannerLeaseTimeoutPeriod, rpcTimeout) / 2, and will response
> heartbeat message if we reach this limit. However, two timeout settings
> (hbase.client.scanner.timeout.period and hbase.rpc.timeout) are read from
> RS's configure, which may be different from client's. If client's setting is
> much less than server's, there may still be timeout at client side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
