[
https://issues.apache.org/jira/browse/HBASE-15819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284169#comment-15284169
]
Anoop Sam John commented on HBASE-15819:
----------------------------------------
I see.. then need to careful see why that missing.. Do we really need any such
lock and that is missing (wait) in these 2 branches..
> Cleanup unused lock in MultiVersionConsistencyControl in branch-1.0 and 1.1
> ---------------------------------------------------------------------------
>
> Key: HBASE-15819
> URL: https://issues.apache.org/jira/browse/HBASE-15819
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HBASE-15819-branch-1.0.patch,
> HBASE-15819-branch-1.1.patch
>
>
> In MultiVersionConsistencyControl of branch-1.0 and branch-1.1, there is a
> unused lock readWaiters, it is only referenced by {{boolean
> advanceMemstore(WriteEntry e)}},
> {code}
> if (nextReadValue > 0) {
> synchronized (readWaiters) {
> readWaiters.notifyAll();
> }
> }
> {code}.
> Thus the readerWaiters.notifyAll() is not necessary, and could be cleaned up
> from the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
