[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284425#comment-15284425
]
Anoop Sam John commented on HBASE-14920:
----------------------------------------
Mainly gone through changed files this time. On the new memstore impl class
raised some comments already and as discussed we can address in follow up
issues also.
{code}
if(hasSloppyStores) {
950
htableDescriptor.setFlushPolicyClassName(FlushNonSloppyStoresFirstPolicy.class
951 .getName());
952 LOG.info("Setting FlushNonSloppyStoresFirstPolicy for the
region=" + this);
953 }
{code}
How this works? Why we need? Will it be persisted to HTD?
Still some code style issues like
public ThreadPoolExecutor getInMemoryCompactionPool() { return
INMEMORY_COMPACTION_POOL; }
This pool is in RegionServicesForStores which is one per Region. Better avoid
this and have a single pool at RS level. Here #threads depends on #Regions and
will be an issue when we have more regions per RS. This was discussed already
and accepted comment I believe. (?)
assertMinSequenceId Where it is used? Why?
Regarding flush to disk in case of system generated flush events, it was
discussed to handle and flush whole at once. Did already now or we will do in
following issues?
> Compacting Memstore
> -------------------
>
> Key: HBASE-14920
> URL: https://issues.apache.org/jira/browse/HBASE-14920
> Project: HBase
> Issue Type: Sub-task
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Attachments: HBASE-14920-V01.patch, HBASE-14920-V02.patch,
> HBASE-14920-V03.patch, HBASE-14920-V04.patch, HBASE-14920-V05.patch,
> HBASE-14920-V06.patch, HBASE-14920-V07.patch, HBASE-14920-V08.patch,
> HBASE-14920-V09.patch, move.to.junit4.patch
>
>
> Implementation of a new compacting memstore with non-optimized immutable
> segment representation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
