[ 
https://issues.apache.org/jira/browse/HBASE-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287691#comment-15287691
 ] 

Appy commented on HBASE-15841:
------------------------------

Good we already have fatal exception.

bq. opts.size will be the default in that last case
Shouldn't correct value of opts.size in last case be "1.0f*num clients" GB.
The reason why i asked for updating the size is, if in future, new logic is 
added downstream which depends on size, it'll get incorrect size when --rows is 
specified. If the person making the change is lucky, he/she might figure out 
the bug sooner, in worst case, the bug will lie around until someone spends a 
bit of time going back and debugging it.
Bottom line, have a set of mutually inconsistent values in TestOptions can lead 
to bug in future.


> Performance Evaluation tool total rows may not be set correctly
> ---------------------------------------------------------------
>
>                 Key: HBASE-15841
>                 URL: https://issues.apache.org/jira/browse/HBASE-15841
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.2
>
>         Attachments: HBASE-15841-branch-1.patch, HBASE-15841-master.patch
>
>
> Carried my comment on HBASE-15403 to here:
> Recently when I ran PerformanceEvaluation, I did notice some problem with the 
> number of rows.
> hbase org.apache.hadoop.hbase.PerformanceEvaluation --table=TestTable1 
> randomWrite 1
> hbase org.apache.hadoop.hbase.PerformanceEvaluation --table=TestTable5 
> randomWrite 5
> hbase org.apache.hadoop.hbase.PerformanceEvaluation --table=TestTable10 
> randomWrite 10
> hbase org.apache.hadoop.hbase.PerformanceEvaluation --table=TestTable10 
> randomWrite 20
> All produced similar number of rows, and on the file system, they look like 
> in similar size as well:
> hadoop fs -du -h /apps/hbase/data/data/default
> 786.5 M /apps/hbase/data/data/default/TestTable1
> 786.0 M /apps/hbase/data/data/default/TestTable10
> 782.0 M /apps/hbase/data/data/default/TestTable20
> 713.4 M /apps/hbase/data/data/default/TestTable5
> HBase is 1.2.0. Looks like a regression somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to