[
https://issues.apache.org/jira/browse/HBASE-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295815#comment-15295815
]
Hiroshi Ikeda commented on HBASE-15802:
---------------------------------------
This is another issue but
{code}
+ long jitter = (long) (normalPause * ...
return normalPause + jitter;
{code}
I just realized that there is a little worry about overflow, which may be not a
problem in practice but can be easily avoidable by adding jitter before casting
it to long.
> ConnectionUtils should use ThreadLocalRandom instead of Random
> ---------------------------------------------------------------
>
> Key: HBASE-15802
> URL: https://issues.apache.org/jira/browse/HBASE-15802
> Project: HBase
> Issue Type: Improvement
> Reporter: Hiroshi Ikeda
> Assignee: Matt Warhaftig
> Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: hbase-15802.patch
>
>
> {code}
> public final class ConnectionUtils {
> ...skip...
> private static final Random RANDOM = new Random();
> {code}
> In general, static fields are accessed by multi-threads. The class Random is
> thread-safe but ThreadLocalRandom is more preferable because of less
> contention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
