[jira] [Commented] (HBASE-15844) We should respect hfile.block.index.cacheonwrite when write intermediate index Block

[Heng Chen (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295871#comment-15295871
 ] 

Heng Chen commented on HBASE-15844:
-----------------------------------

Any suggestions?  [~anoop.hbase] [~carp84]

> We should respect hfile.block.index.cacheonwrite when write intermediate 
> index Block
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15844
>                 URL: https://issues.apache.org/jira/browse/HBASE-15844
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>
> {code: title=BlockIndexWriter#writeIntermediateBlock}
>       if (cacheConf != null) {
>         HFileBlock blockForCaching = 
> blockWriter.getBlockForCaching(cacheConf);
>         cacheConf.getBlockCache().cacheBlock(new BlockCacheKey(nameForCaching,
>           beginOffset, true, blockForCaching.getBlockType()), 
> blockForCaching);
>       }
> {code}
> The if condition should be ?
> {code}
> if (cacheConf != null && cacheConf.shouldCacheIndexesOnWrite()) 
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)