[
https://issues.apache.org/jira/browse/HBASE-15876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296888#comment-15296888
]
Hudson commented on HBASE-15876:
--------------------------------
SUCCESS: Integrated in HBase-1.3-IT #675 (See
[https://builds.apache.org/job/HBase-1.3-IT/675/])
HBASE-15876 Remove doBulkLoad(Path hfofDir, final HTable table) though (stack:
rev e3e3b64ecdae162e8c533de12f7de1508a2219a1)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
Revert "HBASE-15876 Remove doBulkLoad(Path hfofDir, final HTable table) (stack:
rev 39c1f795ee13a6c1edd198ce1b026c0ef6be62a7)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
> Remove doBulkLoad(Path hfofDir, final HTable table) though it has not been
> through a full deprecation cycle
> -----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-15876
> URL: https://issues.apache.org/jira/browse/HBASE-15876
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: stack
> Assignee: Jurriaan Mous
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15876.patch
>
>
> HBASE-15875 purges the properly deprecated HTable. The method doBulkLoad(Path
> hfofDir, final HTable table), while it has a deprecated param, the method
> itself did not get a deprecation label; it is a public method in a public
> class marked stable. This issue is about getting consensus that it is ok to
> remove this method used by offline tooling that will break until updated on
> upgrade to 2.0 w/o a proper deprecation cycle (I think it will be ok to do
> this -- the benefit of our being able to remove HTable is worth this minor
> inconvenience). We'll do some ugly patching of this oversight by adding a
> late deprecation and flagging the removal of this offline method as an
> incompatible change in 2.0. We'll add the deprecation in a subissue.
> It is a problem removing
> doBulkLoad(Path hfofDir, final HTable table)
> ... since this is a public/stable Class.
> There is the alternate:
> public void doBulkLoad(Path hfofDir, final Admin admin, Table table,
> RegionLocator regionLocator) throws TableNotFoundException, IOException
> {
> The former calls the latter.
> The latter went in here:
> {code}
> commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739
> Author: tedyu <[email protected]>
> Date: Fri Jan 2 19:48:06 2015 -0800
> HBASE-12783 Create efficient RegionLocator implementation (Solomon Duskis)
> {code}
> This was added in time for release 1.1.0.
> So, this method has not gone through a full major version of deprecation.
> It will break when someone moves to 2.0. But it is offline method. Not the
> end of the world.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
