[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304537#comment-15304537
]
Elliott Clark commented on HBASE-15893:
---------------------------------------
-1
* Auto generated everywhere. If code isn't needed and already used it shouldn't
be here. Remove everything that's not 100% needed.
* Makefile overcommit
* There's no need to have a byte comparable when string already has all that.
* Don't need cell and key value. There's no off heap. We've made no promises
about kv's aways being in the same contiguous memory so there's no need to have
the distinction.
* hconstants is an abomination and should never ever be repeated.
* Don't create a new object and then add it into a unique pointer. Use
make_unique
* Prefer the protobuf whenever it's api is palatable.
* B after H is always capital.
* Utils is an awful class name
* Right now I don't even think that we want to try implementing kv/cell. The
protobufs have been doing very well in perf tests.
* Tests. These all need tests. If things aren't covered by tests I'm not ok
with committing it.
> Get object
> ----------
>
> Key: HBASE-15893
> URL: https://issues.apache.org/jira/browse/HBASE-15893
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Attachments: HBASE-15893.HBASE-14850.v1.patch
>
>
> Patch for creating Get objects. Get objects can be passed to the Table
> implementation to fetch results for a given row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
