[
https://issues.apache.org/jira/browse/HBASE-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305049#comment-15305049
]
stack commented on HBASE-15610:
-------------------------------
This is the only dodgy looking thing that I see:
{code}
1170 protected AdminProtos.AdminService.BlockingInterface getAdmin(final
ServerName serverName,
1254 final boolean master) 1171
{code}
We go from public to protected. It is in a Deprecated class but you seem to
move the difference between HConnection and ClusterConnection into CC elsewhere
except here. Maybe you have reasoning? Might be less risky leaving this public
but deprecating it? (It looks like it is useless/unused so could do the
above...)
Otherwise, +1.
> Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
> -----------------------------------------------------------------------------
>
> Key: HBASE-15610
> URL: https://issues.apache.org/jira/browse/HBASE-15610
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Jurriaan Mous
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15610.patch, HBASE-15610.patch,
> HBASE-15610.v1.patch
>
>
> This is sub-task for HBASE-15174.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)