[
https://issues.apache.org/jira/browse/HBASE-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307195#comment-15307195
]
stack commented on HBASE-15915:
-------------------------------
Talking more with @appy offline, he says 'atomic test' is a single test, a
single method.
Chatting even more, our refguide is ambigious on what how long a Medium/Small
test should run. It looks like the 50 seconds for a medium test is for the
whole testcase, not for an individual test as we currently do. That would make
the addition here by @appy of a #forClass more 'correct'. See HBASE-15919
> Set timeouts on hanging tests
> -----------------------------
>
> Key: HBASE-15915
> URL: https://issues.apache.org/jira/browse/HBASE-15915
> Project: HBase
> Issue Type: Sub-task
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0
>
> Attachments: HBASE-15915.master.001.patch,
> HBASE-15915.master.002.patch
>
>
> - We annotate tests as Small/Medium/Large and define time limits for each, we
> should use them so tests fail fast and we can run Flaky-Tests job more
> frequently.
> - It'll be hard to do so for all existing tests (1200+ Test*.java files), but
> I'd like to do it for at least those known to hang up. (Found by using
> report-flakies.py on TRUNK)
> - In some places, we have @Rule Timeout but it actually sets timeout for
> atomic tests.
> Basically we can't go the way where we define time limits on class level
> (Small/Medium/Large tests) and try to enforce timeouts on atomic tests level.
> It would be painful (probably why no one has done it yet).
> So i'll be changing these timeouts to
> {noformat}
> @ClassRule
> public static final TestRule timeout =
> CategoryBasedTimeout.forClass(<test_class>);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
