[ 
https://issues.apache.org/jira/browse/HBASE-15930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310634#comment-15310634
 ] 

Elliott Clark commented on HBASE-15930:
---------------------------------------

It's a test. I'm totally ok with any breaking change as long as the benefits 
are there. So I don't think that we need to worry about backward compat. Just 
do whatever you think is the best api and I'll change our test rig when it goes 
in.

> Make IntegrationTestReplication's waitForReplication() smarter
> --------------------------------------------------------------
>
>                 Key: HBASE-15930
>                 URL: https://issues.apache.org/jira/browse/HBASE-15930
>             Project: HBase
>          Issue Type: Improvement
>          Components: integration tests
>            Reporter: Dima Spivak
>            Assignee: Dima Spivak
>
> {{IntegrationTestReplication}} is a great test, but can improved by changing 
> how we handle waiting between generation of the linked list on the source 
> cluster and verifying the linked list on the destination cluster. [Even the 
> code suggests this should be 
> done|https://github.com/apache/hbase/blob/master/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java#L251-252],
>  so I'd like to take it on. [~mbertozzi] and [~busbey] have both suggested a 
> simple solution wherein we write a row into each region on the source cluster 
> after the linked list generation and then assume replication has gone through 
> once these rows are detected on the destination cluster.
> Since you lads at Facebook are some of the heaviest users, [~eclark], would 
> you prefer I maintain the API and add a new command line option (say {{\-c | 
> \-\-check-replication}}) that would run before any {{--generateVerifyGap}} 
> sleep is carried out as it is now?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to