[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-15174:
-------------------------------------------
Attachment: HBASE-15174_3.patch
[~enis]
I have updated the patch with your suggestion. Now infact the test case tries
not to include any method or constructor that has an annotation as IA.Private.
My intention in the previous patch was to totally remove protos from the Public
interfaces. The wrapper was looking ugly I agree.
So from now on if some one adds a public constructor or method and that accepts
Protos and if it is not marked IA.Private the test case will fail.
> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
> ....
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
> ....
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
