[ 
https://issues.apache.org/jira/browse/HBASE-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313884#comment-15313884
 ] 

Appy commented on HBASE-15929:
------------------------------

v2 moves the test to regionserver package.

> There are two classes with name TestRegionServerMetrics
> -------------------------------------------------------
>
>                 Key: HBASE-15929
>                 URL: https://issues.apache.org/jira/browse/HBASE-15929
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Appy
>         Attachments: HBASE-15929.master.001.patch, 
> HBASE-15929.master.002.patch
>
>
> Moved 
> ./hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionServerMetrics.java
>   to  ../regionserver/TestRegionServerReadRequestMetrics.java.
> I think it's great that these tests for checking metrics of a particular 
> feature are contained in separate file.
> If we put all metrics' tests in one file, it might become monolithic. The 
> overhead of setting/destroying separate cluster (12-15 sec) doesn't seem much 
> to me since we run multiple forks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to