[
https://issues.apache.org/jira/browse/HBASE-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315250#comment-15315250
]
Hudson commented on HBASE-15845:
--------------------------------
FAILURE: Integrated in HBase-1.4 #193 (See
[https://builds.apache.org/job/HBase-1.4/193/])
HBASE-15845 Changes: - Remove omnipresence of formatter object since it (appy:
rev 2ee7d2a4882b18001bd5fbe7e5db32d6f75153ca)
* hbase-shell/src/main/ruby/shell.rb
* hbase-shell/src/test/ruby/hbase/visibility_labels_admin_test.rb
* hbase-shell/src/main/ruby/shell/commands.rb
* hbase-shell/src/main/ruby/hbase/quotas.rb
* hbase-shell/src/main/ruby/hbase/admin.rb
* hbase-shell/src/test/ruby/hbase/admin_test.rb
* bin/hirb.rb
* hbase-shell/src/main/ruby/hbase/table.rb
* hbase-shell/src/test/ruby/shell/shell_test.rb
* hbase-shell/src/test/ruby/shell/noninteractive_test.rb
* hbase-shell/src/test/ruby/hbase/replication_admin_test.rb
* hbase-shell/src/main/ruby/hbase/replication_admin.rb
* hbase-shell/src/test/ruby/test_helper.rb
* hbase-shell/src/main/ruby/hbase/hbase.rb
* hbase-shell/src/main/ruby/hbase/visibility_labels.rb
* hbase-shell/src/test/ruby/hbase/security_admin_test.rb
* hbase-shell/src/main/ruby/hbase/security.rb
* hbase-shell/src/main/ruby/hbase/taskmonitor.rb
* hbase-shell/src/test/ruby/hbase/hbase_test.rb
> Shell Cleanup : move formatter to commands.rb; move one of the two hbase.rb
> to hbase_constants.rb
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-15845
> URL: https://issues.apache.org/jira/browse/HBASE-15845
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-15845-master-v1.patch, HBASE-15845-master-v2.patch
>
>
> - Renaming hbase.rb to hbase_constants.rb because there are two hbase.rb
> files right now which is confusing. The constants are meant for shell, users
> shouldn't be using it directly. Anyways, this file is moved only in 2.0. In
> earlier branches, the files isn't renamed.
> - Remove omnipresence of formatter object since it is kind of a use-and-throw
> class. Commands should create
> an instance, use it to format the output and discard it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
