[jira] [Commented] (HBASE-15979) replication_admin_test.rb fails in 0.98 branch

[Ted Yu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319007#comment-15319007
 ] 

Ted Yu commented on HBASE-15979:
--------------------------------

After adding exception message to the log:
{code}
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
index 632894c..0be7278 100644
--- 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
+++ 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
@@ -141,7 +141,7 @@ public class ReplicationPeersZKImpl extends 
ReplicationStateZKBase implements Re
       }
       ZKUtil.deleteNodeRecursively(this.zookeeper, 
ZKUtil.joinZNode(this.peersZNode, id));
     } catch (KeeperException e) {
-      throw new ReplicationException("Could not remove peer with id=" + id, e);
+      throw new ReplicationException("Could not remove peer with id=" + id + 
e.getMessage(), e);
     }
   }

{code}
I saw:
{code}
  1) Error:
test_add_peer:_multiple_zk_cluster_key(Hbase::ReplicationAdminTest):
NativeException: org.apache.hadoop.hbase.replication.ReplicationException: 
Could not remove peer with id=1KeeperErrorCode = Directory not empty for 
/hbase/replication/peers/1
    org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:144:in 
`removePeer'
    org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java:229:in 
`removePeer'
    /home/hbase/98/hbase-shell/src/main/ruby/hbase/replication_admin.rb:102:in 
`remove_peer'
    ./src/test/ruby/hbase/replication_admin_test.rb:97:in 
`test_add_peer:_multiple_zk_cluster_key'
    org/jruby/RubyProc.java:270:in `call'
    org/jruby/RubyKernel.java:2105:in `send'
    org/jruby/RubyArray.java:1620:in `each'
    org/jruby/RubyArray.java:1620:in `each'
{code}

> replication_admin_test.rb fails in 0.98 branch
> ----------------------------------------------
>
>                 Key: HBASE-15979
>                 URL: https://issues.apache.org/jira/browse/HBASE-15979
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> From 
> https://builds.apache.org/job/HBase-0.98-matrix/jdk=latest1.7,label=yahoo-not-h2/352/testReport/junit/org.apache.hadoop.hbase.client/TestShell/testRunShellTests/
>  :
> {code}
>   1) Error:
> test_add_peer:_multiple_zk_cluster_key_-_peer_config(Hbase::ReplicationAdminTest):
> NativeException: org.apache.hadoop.hbase.replication.ReplicationException: 
> Could not remove peer with id=1
>     org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:144:in 
> `removePeer'
>     org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java:229:in 
> `removePeer'
>     
> /home/jenkins/jenkins-slave/workspace/HBase-0.98-matrix/jdk/latest1.7/label/yahoo-not-h2/hbase-shell/src/main/ruby/hbase/replication_admin.rb:102:in
>  `remove_peer'
>     ./src/test/ruby/hbase/replication_admin_test.rb:140:in 
> `test_add_peer:_multiple_zk_cluster_key_-_peer_config'
>     org/jruby/RubyProc.java:270:in `call'
>     org/jruby/RubyKernel.java:2105:in `send'
>     org/jruby/RubyArray.java:1620:in `each'
>     org/jruby/RubyArray.java:1620:in `each'
> {code}
> The above led to assertion failures for subsequent tests:
> {code}
> 2) Failure:
> test_add_peer:_multiple_zk_cluster_key_-_peer_config(Hbase::ReplicationAdminTest)
>     [./src/test/ruby/hbase/replication_admin_test.rb:41:in `teardown'
>      org/jruby/RubyArray.java:1620:in `each'
>      org/jruby/RubyArray.java:1620:in `each']:
> <0> expected but was
> <1>.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)