[
https://issues.apache.org/jira/browse/HBASE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154771#comment-13154771
]
jirapos...@reviews.apache.org commented on HBASE-4797:
------------------------------------------------------
bq. On 2011-11-21 22:47:55, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line
2456
bq. > <https://reviews.apache.org/r/2906/diff/2/?file=59652#file59652line2456>
bq. >
bq. > So, are these already sorted in right order from oldest edit to
newest?
All these files are under the same folder, if these files have the same name
pattern as defined in HLog: String.format("%019d", seqid);
yes, they are sorted in the right order based on the sequence id number.
If this is not true, then the order to reapply these edits is already wrong.
bq. On 2011-11-21 22:47:55, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line
2475
bq. > <https://reviews.apache.org/r/2906/diff/2/?file=59652#file59652line2475>
bq. >
bq. > Possilbe should be Possible.
bq. >
bq. > I'd be more assertive in this message. "Maximum possible sequenceid
for this log is " + + ", skipping ..
Sure, I will fix it.
bq. On 2011-11-21 22:47:55, Michael Stack wrote:
bq. > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java,
line 2855
bq. > <https://reviews.apache.org/r/2906/diff/2/?file=59653#file59653line2855>
bq. >
bq. > Any more asserts we can do in here? Assert we replayed N of the M
files?
Sure, I added more test cases.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2906/#review3409
-----------------------------------------------------------
On 2011-11-21 22:38:39, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2906/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-21 22:38:39)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If there are multiple recovered edits files, I used the file name to find
the initial sequence id. After these files are sorted, we can find a file's
possible maximum sequence id based on the next file's initial sequence id. If
the maximum sequence id is smaller than the current sequence id, the whole
recovered edits file is old and ignored.
bq.
bq.
bq. This addresses bug HBASE-4797.
bq. https://issues.apache.org/jira/browse/HBASE-4797
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8b89661
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
5daa02b
bq.
bq. Diff: https://reviews.apache.org/r/2906/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test case to TestHRegion, and all the tests in this test are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> [availability] Skip recovered.edits files with edits we know older than what
> region currently has
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4797
> URL: https://issues.apache.org/jira/browse/HBASE-4797
> Project: HBase
> Issue Type: Bug
> Components: performance
> Reporter: stack
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
>
> Testing 0.92, I crashed all servers out. Another bug makes it so WALs are
> not getting cleaned so I had 7000 regions to replay. The distributed split
> code did a nice job and cluster came back but interesting is that some hot
> regions ended up having loads of recovered.edits files -- tens if not
> hundreds -- to replay against the region (can we bulk load recovered.edits
> instead of replaying them?). Each recovered.edits file is taking about a
> second to process (though only about 30 odd edits per file it seems). The
> region is unavailable during this time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
